Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] remove SiPixelCompare*SoAAlpaka templates and update customizeHLTforAlpaka to use the new modules #45586

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 30, 2024

backport of #45566

PR description:

After the integration of the new HLT menu in PR #45549 (which included the ticket CMSHLT-3278 "[DQM] Use general DQM modules for pixel rechits, tracks and vertices added in cmssw#45302") we can finally proceed with removing the old-style comparison SiPixelCompare*SoAAlpaka templates which serve no longer any purpose.
Consequently the customizeHLTforAlpaka customization function is updated to use the new modules.
This is a "leftover" of #45302, see comment at #45206 (comment).

PR validation:

None, no regressions are expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim cleanup backport of #45566 to CMSSW_14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/SiPixelHeterogeneous (dqm)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fioriNTU, @idebruyn, @jandrea, @missirol, @silviodonato, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a170b3/40688/summary.html
COMMIT: d8364ab
CMSSW: CMSSW_14_0_X_2024-07-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45586/40688/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2024

+hlt

@tjavaid
Copy link

tjavaid commented Jul 30, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b23424 into cms-sw:CMSSW_14_0_X Jul 30, 2024
9 checks passed
@mmusich mmusich deleted the mm_dev_rmSiPixelCompareStuffSoAAlpaka_14_0_X branch July 30, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants