Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demangled log printout of Pedereader #45588

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

phnattla
Copy link
Contributor

@phnattla phnattla commented Jul 30, 2024

PR description:

Demangled PedeReader output to make logs more readable

PR validation:

Used the following command to validated the changes:

cmsDriver.py stepHarvest2 -s ALCAHARVEST:SiPixelAliHGCombined --conditions 140X_dataRun3_Express_v3 --scenario pp --data --dasquery='file dataset=/StreamExpress/Run2024F-PromptCalibProdSiPixelAliHGComb-Express-v1/ALCAPROMPT run=383496' --custom_conditions=PCLThresholds_HG_Test_01,AlignPCLThresholdsHGRcd,frontier://FrontierPrep/CMS_CONDITIONS

@mmusich @henriettepetersen @TomasKello

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @phnattla for master.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 30, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Jul 31, 2024

Uhm tests seem stuck here

@mmusich
Copy link
Contributor

mmusich commented Jul 31, 2024

@cmsbuild ping?

@mmusich
Copy link
Contributor

mmusich commented Aug 1, 2024

tests seem stuck here. @smuzaffar can you unstuck them?

@smuzaffar
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f354a/40710/summary.html
COMMIT: b3a7c90
CMSSW: CMSSW_14_1_X_2024-07-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45588/40710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423948
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 98c5815 into cms-sw:master Aug 3, 2024
11 checks passed
@mmusich
Copy link
Contributor

mmusich commented Aug 5, 2024

@phnattla can you backport it as well?

@phnattla
Copy link
Contributor Author

phnattla commented Aug 5, 2024

@phnattla can you backport it as well?

Sure, I can look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants