Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation/RecoEgamma Phase2 vertex_pt correction #45590

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

archiron
Copy link
Contributor

PR description:

Adding two plots to better monitor the selection of electrons done at the miniAOD level
we can see the effect before :
Capture d’écran du 2024-07-30 14-31-33

and after the correction :
Capture d’écran du 2024-07-30 14-32-02

Tests have been made also for RECO and did not show any change.
The files into the Validation/RecoEgamma/test folder are only for local tests

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.

runTheMatrix.py -l limited -i all --ibeos tests are fine
47 46 45 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed
runall-report-step123-.log

@beaudett

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @archiron for master.

It involves the following packages:

  • Validation/RecoEgamma (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Aug 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b32b5c/40829/summary.html
COMMIT: 02caf03
CMSSW: CMSSW_14_1_X_2024-08-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45590/40829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 94 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 2463
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3421487
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 41.51399999999998 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 0.520 KiB EgammaV/ElectronMcSignalValidatorMiniAOD
  • DQMHistoSizes: changed ( 10224.0,... ): 0.518 KiB EgammaV/ElectronMcSignalValidatorPt1000
  • DQMHistoSizes: changed ( 10224.0,... ): 0.506 KiB EgammaV/ElectronMcSignalValidator
  • DQMHistoSizes: changed ( 23234.0,... ): 0.867 KiB EgammaV/ElectronMcSignalValidatorMiniAOD
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants