Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cleanup for big simulation plugin #45607

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

smuzaffar
Copy link
Contributor

This PR proposes to

  • If cuda is not available for cmssw then
    • CondFormats/EcalObjects CondFormats/HcalObjects: Do not build *GPU.cc
    • CondFormats/HGCalObjects: Do not build HeterogeneousHGCalHEFCellPositionsConditions.cc`
  • Remove used geant4core dependency from Validation/HGCalValidation
  • Drop Validation/HGCalValidation (which now does not depend on geant4) from Simulation big plugin

These changes should allow to build buig Simulation plugin for Riscv 64

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • BigProducts/Simulation (simulation, core)
  • CondFormats/EcalObjects (db, alca)
  • CondFormats/HGCalObjects (upgrade, db, alca)
  • CondFormats/HcalObjects (db, alca)
  • Validation/HGCalValidation (dqm)

@Dr15Jones, @antoniovagnerini, @civanch, @cmsbuild, @consuegs, @francescobrivio, @makortel, @mdhildreth, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @smuzaffar, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @cseez, @hatakeyamak, @lecriste, @lgray, @missirol, @mmusich, @pfs, @rchatter, @rovere, @rsreds, @seemasharmafnal, @sethzenz, @thomreis, @tocheng, @vandreev11, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

Please test

@civanch
Copy link
Contributor

civanch commented Jul 31, 2024

@bsunanda , FYI , for me this PR is fine.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd4355/40705/summary.html
COMMIT: b8b76c8
CMSSW: CMSSW_14_1_X_2024-07-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45607/40705/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423961
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423938
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@civanch
Copy link
Contributor

civanch commented Aug 1, 2024

+1

@makortel
Copy link
Contributor

makortel commented Aug 1, 2024

+core

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Aug 1, 2024

@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this change? This change practically do not change any thing. It only avoids compilation of *GPU.cc files is cuda is not available ( e.g. on riscv64 arch).

@cms-sw/dqm-l2 , this Pr only removes the unused geant4 dependency from Validation/HGCalValidation

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2024

+1

@smuzaffar
Copy link
Contributor Author

@cms-sw/dqm-l2 , can you please review this? for DQM the change is really trivial i.e. remove unnecessary geant4 dependency

@tjavaid
Copy link

tjavaid commented Aug 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 643935a into cms-sw:master Aug 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants