Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary VDT dependency in Geometry/CommonTopologies #45622

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Working on a minimal code subset for MiniAOD reading found this dependency.

PR validation:

Code compiles.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Geometry/CommonTopologies (geometry)

@Dr15Jones, @bsunanda, @civanch, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @VourMa, @bsunanda, @fabiocos, @martinamalberti, @mmusich, @mtosi this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5df289/40727/summary.html
COMMIT: 0bd0e58
CMSSW: CMSSW_14_1_X_2024-08-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45622/40727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Aug 2, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5f0beb2 into cms-sw:master Aug 2, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the remove_vdt branch August 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants