Replace patterns with explicit class names in TrackingTools/PatternTools/src/classes_def.xml, and move the dictionaries of GlobalErrorBase to a proper package

[makortel]

PR description:

This PR is part of series to replace the last remaining uses class pattern elements in classes_def.xml with explicit class names. In addition, it removes (now-)unnecessary code from classes.h, adds persistent="false" to all edm::Wrapper<T> instantiations and removes it from other classes, and finally moves GlobalErrorBase (and Point3DBase) related dictionaries to DataFormats/GeometryCommonDetAlgo that seemed like the right place (it seems to me these dictionaries were defined in TrackingTools/PatternTools because of typedef std::pair<GlobalPoint, GlobalError> VertexConstraint type alias used there; I also hope the "ROOT6 problem" mentioned in the comment has been solved already).

Resolves cms-sw/framework-team#980

PR validation:

Code compiles. The pattern-to-name change kept all existing definitions in the .rootmap file, and added a few more with that use the type aliases I used in the name attribute.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45623/41127

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• DataFormats/GeometryCommonDetAlgo (simulation)
• TrackingTools/PatternTools (reconstruction)

@civanch, @cmsbuild, @jfernan2, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @JanFSchulte, @VinInn, @VourMa, @abbiendi, @andrea21z, @bellan, @cericeci, @dgulhan, @felicepantaleo, @gpetruc, @jhgoh, @missirol, @mmusich, @mtosi, @rovere, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

type -changes-dataformats

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb82ed/40730/summary.html
COMMIT: 6544cff
CMSSW: CMSSW_14_1_X_2024-08-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45623/40730/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.784.78_WElSkim2012D/step2_WElSkim2012D.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 236 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3530500
• DQMHistoTests: Total failures: 4339
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3526141
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 200 log files, 170 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[makortel]

The failure in 4.78 is a file open error. Comparison differences are related to #39803

[civanch]

please test

there are PRs today, which pass tests.

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb82ed/40748/summary.html
COMMIT: 6544cff
CMSSW: CMSSW_14_1_X_2024-08-04-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45623/40748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3530500
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3528016
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 200 log files, 170 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.