Avoid compilation errors in L1Trigger/Phase2L1GMT/src/KMTFCore.cc

[dan131riley]

PR description:

L1Trigger/Phase2L1GMT/src/KMTFCore.cc has compilation warnings in gcc12 and errors in gcc13. These appear to be another example of LTO exposing compiler errors. This PR works around the warnings/errors mostly by declaring some SMatrix variables as const.

PR validation:

Compiles, should be a simple technical fix.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45629/41140

[cmsbuild]

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

• L1Trigger/Phase2L1GMT (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf9d7/40750/summary.html
COMMIT: cf1543d
CMSSW: CMSSW_14_1_X_2024-08-04-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45629/40750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423977
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421493
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test for el9_amd64_gcc13

[smuzaffar]

thanks @dan131riley , this has fixed the el9/gcc13 compilation issues https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf9d7/40763/build-logs/

[smuzaffar]

@cms-sw/l1-l2 can you please review this? This should fix the build errors for el9/gcc13 IBs

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf9d7/40763/summary.html
COMMIT: cf1543d
CMSSW: CMSSW_14_1_X_2024-08-02-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45629/40763/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_MC_23_setup had ERRORS

Comparison Summary

Summary:

• You potentially added 460 lines to the logs
• Reco comparison results: 61051 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423977
• DQMHistoTests: Total failures: 235720
• DQMHistoTests: Total nulls: 373
• DQMHistoTests: Total successes: 3187864
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4.8309999999999995 KiB( 44 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 1.986 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.719 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 2.702 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
• Checked 196 log files, 165 edm output root files, 45 DQM output files