Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplacedJet_Monitor: use hltIter2MergedForDisplaced instead of hltIter2MergedForBTag to (as per CMSHLT-3303) #45632

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 5, 2024

PR description:

Title says it all, as per discussion at CMSHLT-3303.
The collection hltIter2MergedForDisplaced produced at HLT by few displaced object triggers is not monitored by the EXO monitoring setup in HLTMonitor. This PR jointly with a HLT menu change foreseen for Aug-5 2024 will restore the monitoring.

PR validation:

None, trivial input collection change.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will be backported to CMSSW_14_0_X for 2024 data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1523/40757/summary.html
COMMIT: 98a7d7e
CMSSW: CMSSW_14_1_X_2024-08-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45632/40757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422943
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422920
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.01 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.166 KiB HLT/EXO
  • DQMHistoSizes: changed ( 141.044,... ): -0.173 KiB HLT/EXO
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2024

@cms-sw/dqm-l2, sorry to pressure you. We could use the backport of this PR #45633 in the upcoming release for data-taking, can you have a look?

@tjavaid
Copy link

tjavaid commented Aug 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 10ceefa into cms-sw:master Aug 6, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_renameIter2 branch August 6, 2024 11:15
@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2024

just to answer publicly a (legitimate) question that @tjavaid made me in private.

With this update, I see the plots are redirected but are still empty (see for WF 13034.0 plots). Do you expect them to be populated e.g. from the latest dataset ?

no, because the current HLT menu in release doesn't save the needed collection (hltIter2MergedForDisplaced), see:

FEVTDEBUGHLTEventContent.outputCommands.extend(HLTDebugFEVT.outputCommands)

When applying by hand the following commit cms-tsg-storm@23245df (that will become available in the next trigger train release) and re-running wf 13034.0 I get entries in the monitoring plots:

Screenshot from 2024-08-06 13-55-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants