Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another apptainer workaround [14_0_X] #45653

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Aug 6, 2024

backport of #45652

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

A new Pull Request was created by @kpedro88 for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/SonicTriton (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @riga, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

cms-bot internal usage

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 6, 2024

please test

@makortel
Copy link
Contributor

makortel commented Aug 6, 2024

@cmsbuild, please test for slc7_amd64_gcc12

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646200/40806/summary.html
COMMIT: 92986a5
CMSSW: CMSSW_14_0_X_2024-08-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45653/40806/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646200/40808/summary.html
COMMIT: 92986a5
CMSSW: CMSSW_14_0_X_2024-08-05-1100/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45653/40808/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_MC_23_setup had ERRORS

Comparison Summary

Summary:

  • You potentially added 76 lines to the logs
  • Reco comparison results: 62424 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3343220
  • DQMHistoTests: Total failures: 257075
  • DQMHistoTests: Total nulls: 270
  • DQMHistoTests: Total successes: 3085855
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.377 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.673 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 46 workflows

@makortel
Copy link
Contributor

makortel commented Aug 7, 2024

el8 comparison differences are related to #39803 and #45505

slc7 unit test failure should get fixed with backport of #45614

@makortel
Copy link
Contributor

makortel commented Aug 7, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c1c3a23 into cms-sw:CMSSW_14_0_X Aug 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants