Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary xz dependency from GeneratorProducts #45657

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The dependency is not needed for compiling or linking.

PR validation:

Code compiles and links.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 6, 2024
@Dr15Jones Dr15Jones changed the title Removed unnecessary xz dependey from GeneratorProducts Removed unnecessary xz dependency from GeneratorProducts Aug 6, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • SimDataFormats/GeneratorProducts (generators)

@bbilin, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @fabiocos, @martinamalberti, @missirol, @mmusich, @rovere, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f11868/40813/summary.html
COMMIT: e852637
CMSSW: CMSSW_14_1_X_2024-08-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45657/40813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423951
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor Author

@cms-sw/generators-l2 please review

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 could you please bypass the generator signature? This is purely a technical change and the L2s are not responding.

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 It has been two weeks, please override the generator signature.

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d34e3af into cms-sw:master Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants