Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] pileup profile for RunIII2024Summer24 MC compaign (backport) #45687

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

DickyChant
Copy link

@DickyChant DickyChant commented Aug 12, 2024

PR description:

Backport of #45474

Introducing pileup profiles for RunIII2024Summer24 MC compaigns

PR validation:

Tested with CMSSW runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Since this PR will be used for 2024 MC campaigns, it is intended to be packported to 14_0_X (as described in recent PPD news

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @DickyChant for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • SimGeneral/MixingModule (simulation)

@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2024

cms-bot internal usage

@civanch
Copy link
Contributor

civanch commented Aug 12, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/40870/summary.html
COMMIT: bfb8f6c
CMSSW: CMSSW_14_0_X_2024-08-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45687/40870/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

SyntaxError: invalid syntax

gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1997: CompilePython] Error 1
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-08-11-2300'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1883: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-08-11-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Configuration/StandardSequences


@iarspider
Copy link
Contributor

@DickyChant please remove merge marks

@DickyChant
Copy link
Author

@DickyChant please remove merge marks

Jesus my bad........

@cmsbuild
Copy link
Contributor

Pull request #45687 was updated. @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mdhildreth, @rappoccio can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Aug 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/40873/summary.html
COMMIT: ad4143d
CMSSW: CMSSW_14_0_X_2024-08-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45687/40873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Aug 12, 2024

+1

@antoniovilela
Copy link
Contributor

+1

@DickyChant
Copy link
Author

DickyChant commented Aug 20, 2024

@DickyChant It seems this got a conflict after #45686 was merged.

I see, I guess it was related to the fact that the original PR #45474 is going after the original PR of #45686 (i.e. #44686) ...

@cmsbuild
Copy link
Contributor

Pull request #45687 was updated. @cmsbuild can you please check and sign again.

@DickyChant
Copy link
Author

@DickyChant It seems this got a conflict after #45686 was merged.

I just resolved the conflict... apologize for the mess!

@civanch
Copy link
Contributor

civanch commented Aug 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41036/summary.html
COMMIT: 1482449
CMSSW: CMSSW_14_0_X_2024-08-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45687/41036/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41036/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41036/git-merge-result

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Aug 20, 2024

is it possible to avoid the nasty merge commit by rebasing?

@DickyChant
Copy link
Author

is it possible to avoid the nasty merge commit by rebasing?

Did my exercise in the afternoon, not seems to work (since I cannot find a proper old-release to based on...)

@mmusich
Copy link
Contributor

mmusich commented Aug 20, 2024

cmsrel CMSSW_14_0_X_2024-08-20-1100
cd CMSSW_14_0_X_2024-08-20-1100/src/
cmsenv
git cms-merge-topic 45687
git rebase -i CMSSW_14_0_X
# fix conflicts by hand
git rebase --contine
git cms-init
git push my-cmssw +HEAD:backport_2024_PU

seems to work for me: link

@DickyChant
Copy link
Author

link

agh you mean improve this one? Sure I'll do it

pileup profile for RunIII2024Summer24 MC compaign
@cmsbuild
Copy link
Contributor

Pull request #45687 was updated. @cmsbuild can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41058/summary.html
COMMIT: 602c141
CMSSW: CMSSW_14_0_X_2024-08-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45687/41058/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41058/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf0f8b/41058/git-merge-result

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa72f43 into cms-sw:CMSSW_14_0_X Aug 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants