Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maxD0Significance in UPC primary vertex reco #45690

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Aug 12, 2024

PR description:

Following the feedback gathered during the last HIN Forward PInG meeting, this PR updates the parameter maxD0Significance to 4.0 in the primary vertex producer run in the HIN UPC reconstruction. It only affects workflows using the Run3 UPC era modifier.

@mandrenguyen

PR validation:

Tested with relvals 180,180.1,181,181.1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@mandrenguyen
Copy link
Contributor

please test workflow 180, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • RecoVertex/PrimaryVertexProducer (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @fabiocos, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92ea20/40878/summary.html
COMMIT: 21e7bc7
CMSSW: CMSSW_14_1_X_2024-08-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45690/40878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 349 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3948403
  • DQMHistoTests: Total failures: 3913
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3944470
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 220 log files, 186 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 76a4f99 into cms-sw:master Aug 12, 2024
11 checks passed
@stahlleiton stahlleiton deleted the UPCPV_CMSSW_14_1_X branch August 12, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants