Add electron supercluster eta to NanoAOD content

[RSalvatico]

PR description:

Among the current NanoAOD variables we have the electron eta and the difference (with sign) between the supercluster eta and eta. Since people often want/need to access supercluster eta, I find it an unnecessary complication to have to derive it from deltaEtaSC and eta. Therefore, I propose to add the actual superclusterEta, which is already there for photons. Since superclusterEta was also there in the additional table used for EGMNano, I have removed it from there. For the moment, I would keep deltaEtaSC just so that people using 2024 prompt nanos won't have to make uncomfortable adjustments to their code to pick another variable in the middle of the dataset.

PR validation:

The new variable, superclusterEta, now appears in the standard Nano files and behaves as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

If possible, I would like to have it backported to 140X to make it effective in prompt and in the 2024 MC production.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45703/41324

[cmsbuild]

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[RSalvatico]

type egamma

[RSalvatico]

enable nano

[RSalvatico]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e7ac5/40925/summary.html
COMMIT: 3b7e915
CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45703/40925/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3422478
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 282 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 54913
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 54913
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.788	2.785	0.004 ( +0.1% )	3.36	3.24	+3.7%	6.032	6.036
2500.002	2.901	2.898	0.003 ( +0.1% )	2.97	2.90	+2.4%	6.398	6.414
2500.003	2.848	2.844	0.003 ( +0.1% )	3.10	3.02	+2.7%	6.358	6.365
2500.011	1.450	1.447	0.003 ( +0.2% )	5.84	5.52	+5.7%	2.125	2.399
2500.012	1.909	1.907	0.002 ( +0.1% )	3.16	3.08	+2.6%	2.164	2.590
2500.013	1.765	1.762	0.003 ( +0.2% )	4.60	4.42	+4.0%	2.192	2.500
2500.021	0.022	0.022	0.000 ( +0.0% )	0.99	0.96	+2.9%	2.201	2.373
2500.022	0.022	0.022	0.000 ( +0.0% )	0.93	0.91	+1.9%	2.203	2.374
2500.023	0.022	0.022	0.000 ( +0.0% )	0.95	0.91	+4.3%	2.156	2.240
2500.024	0.022	0.022	0.000 ( +0.0% )	0.73	0.68	+6.2%	2.197	2.471
2500.031	0.035	0.035	0.000 ( +0.0% )	0.89	0.83	+6.9%	2.239	2.433
2500.032	0.036	0.036	0.000 ( +0.0% )	0.89	0.87	+1.9%	2.244	2.399
2500.033	0.037	0.037	0.000 ( +0.0% )	0.81	0.79	+2.8%	2.283	2.483
2500.034	0.036	0.036	0.000 ( +0.0% )	0.83	0.78	+6.0%	2.252	2.464
2500.101	2.646	2.643	0.003 ( +0.1% )	9.03	8.59	+5.2%	6.285	6.936
2500.111	1.330	1.327	0.003 ( +0.2% )	19.77	18.64	+6.0%	2.208	2.215
2500.112	1.735	1.732	0.003 ( +0.2% )	14.64	14.38	+1.8%	2.128	2.298
2500.131	5.194	5.194	0.000 ( +0.0% )	16.07	15.40	+4.3%	1.488	1.544
2500.201	2.478	2.475	0.003 ( +0.1% )	7.69	7.44	+3.4%	5.534	5.591
2500.211	1.592	1.589	0.003 ( +0.2% )	17.62	17.31	+1.8%	1.671	2.296
2500.212	2.033	2.030	0.003 ( +0.1% )	14.06	13.71	+2.6%	1.762	2.388
2500.221	2.006	2.006	0.000 ( +0.0% )	7.83	7.64	+2.5%	1.847	2.436
2500.222	3.072	3.072	0.000 ( +0.0% )	7.59	7.38	+2.9%	1.865	2.521
2500.223	8.888	8.885	0.003 ( +0.0% )	2.81	1.81	+55.7%	1.822	2.543
2500.224	5.515	5.512	0.003 ( +0.1% )	1.12	1.07	+4.5%	2.537	2.473
2500.225	5.533	5.530	0.003 ( +0.1% )	1.02	1.01	+1.0%	2.411	2.467
2500.226	2.973	2.970	0.003 ( +0.1% )	7.59	3.11	+144.5%	2.283	2.516
2500.227	8.972	8.972	0.000 ( +0.0% )	10.32	8.15	+26.6%	1.381	1.504
2500.231	1.407	1.407	0.000 ( +0.0% )	13.19	13.83	-4.6%	1.935	2.204
2500.232	2.145	2.145	0.000 ( +0.0% )	13.92	14.29	-2.6%	1.995	2.291
2500.233	4.670	4.668	0.003 ( +0.1% )	4.88	4.79	+1.9%	2.037	2.307
2500.234	3.307	3.304	0.003 ( +0.1% )	1.51	1.48	+1.4%	2.046	2.083
2500.235	3.317	3.315	0.003 ( +0.1% )	1.41	1.36	+3.4%	2.075	2.111
2500.236	2.085	2.082	0.003 ( +0.1% )	14.11	13.68	+3.1%	2.033	2.294
2500.237	7.977	7.977	0.000 ( +0.0% )	14.66	14.12	+3.8%	1.398	1.570
2500.241	9.405	9.405	0.000 ( +0.0% )	3.76	3.45	+8.8%	1.761	1.960
2500.242	10.331	10.331	0.000 ( +0.0% )	0.89	0.85	+3.6%	1.726	1.728
2500.243	2.712	2.712	0.000 ( +0.0% )	8.29	7.77	+6.7%	1.059	1.065
2500.244	485.976	485.976	0.000 ( +0.0% )	0.57	0.53	+7.9%	1.597	1.673
2500.245	823.224	823.224	0.000 ( +0.0% )	0.76	0.71	+6.6%	1.572	1.681
2500.901	1.749	1.749	0.000 ( +0.0% )	21.81	20.75	+5.1%	1.796	1.826
2500.902	1.598	1.598	0.000 ( +0.0% )	22.07	19.92	+10.8%	1.736	1.758
2500.911	13.931	13.931	0.000 ( +0.0% )	3.33	2.67	+24.9%	1.079	1.077
2500.912	0.310	0.240	0.070 ( +29.3% )	1.60	1.15	+38.8%	0.964	0.963
2500.913	0.110	0.110	0.000 ( +0.0% )	1.16	1.10	+5.0%	0.972	0.970

[vlimant]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e7ac5/40955/summary.html
COMMIT: 3b7e915
CMSSW: CMSSW_14_1_X_2024-08-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45703/40955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3422481
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 664 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 54913
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 54913
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.788	2.785	0.004 ( +0.1% )	3.30	3.35	-1.3%	6.607	6.044
2500.002	2.901	2.898	0.003 ( +0.1% )	2.97	2.98	-0.3%	6.622	6.408
2500.003	2.848	2.844	0.003 ( +0.1% )	3.06	3.07	-0.2%	6.728	6.366
2500.011	1.450	1.447	0.003 ( +0.2% )	5.71	5.72	-0.1%	2.406	2.399
2500.012	1.909	1.907	0.002 ( +0.1% )	3.17	3.17	-0.2%	2.588	2.595
2500.013	1.765	1.762	0.003 ( +0.2% )	4.53	4.56	-0.7%	2.500	2.505
2500.021	0.022	0.022	0.000 ( +0.0% )	0.99	0.99	-0.2%	2.371	2.373
2500.022	0.022	0.022	0.000 ( +0.0% )	0.96	0.96	+0.0%	2.358	2.366
2500.023	0.022	0.022	0.000 ( +0.0% )	0.94	0.95	-1.0%	2.239	2.238
2500.024	0.022	0.022	0.000 ( +0.0% )	0.71	0.73	-2.7%	2.466	2.469
2500.031	0.035	0.035	0.000 ( +0.0% )	0.88	0.84	+4.3%	2.427	2.441
2500.032	0.036	0.036	0.000 ( +0.0% )	0.89	0.93	-4.1%	2.406	2.399
2500.033	0.037	0.037	0.000 ( +0.0% )	0.81	0.80	+0.7%	2.487	2.499
2500.034	0.036	0.036	0.000 ( +0.0% )	0.80	0.81	-1.3%	2.457	2.457
2500.101	2.646	2.643	0.003 ( +0.1% )	8.83	8.97	-1.5%	6.931	6.337
2500.111	1.330	1.327	0.003 ( +0.2% )	20.02	20.00	+0.1%	2.213	2.213
2500.112	1.735	1.732	0.003 ( +0.2% )	15.20	15.78	-3.7%	2.306	2.305
2500.131	5.194	5.194	0.000 ( +0.0% )	15.61	15.83	-1.4%	1.554	1.482
2500.201	2.478	2.475	0.003 ( +0.1% )	7.48	7.91	-5.5%	6.214	5.610
2500.211	1.592	1.589	0.003 ( +0.2% )	17.65	18.25	-3.3%	2.290	2.289
2500.212	2.033	2.030	0.003 ( +0.1% )	14.18	14.40	-1.5%	2.385	2.383
2500.221	2.006	2.006	0.000 ( +0.0% )	7.71	7.88	-2.1%	2.438	2.438
2500.222	3.072	3.072	0.000 ( +0.0% )	7.53	7.55	-0.3%	2.522	2.521
2500.223	8.888	8.885	0.003 ( +0.0% )	2.82	2.79	+1.2%	2.548	2.181
2500.224	5.515	5.512	0.003 ( +0.1% )	1.10	1.11	-1.2%	2.568	2.004
2500.225	5.533	5.530	0.003 ( +0.1% )	1.02	1.03	-0.9%	2.594	2.450
2500.226	2.973	2.970	0.003 ( +0.1% )	7.60	7.71	-1.5%	2.521	2.515
2500.227	8.972	8.972	0.000 ( +0.0% )	10.03	10.16	-1.3%	1.504	1.257
2500.231	1.407	1.407	0.000 ( +0.0% )	13.87	14.21	-2.4%	2.195	2.182
2500.232	2.145	2.145	0.000 ( +0.0% )	14.16	14.32	-1.1%	2.287	2.281
2500.233	4.670	4.668	0.003 ( +0.1% )	4.92	5.05	-2.5%	2.311	2.293
2500.234	3.307	3.304	0.003 ( +0.1% )	1.50	1.52	-1.2%	2.327	2.322
2500.235	3.317	3.315	0.003 ( +0.1% )	1.40	1.41	-1.2%	2.340	2.346
2500.236	2.085	2.082	0.003 ( +0.1% )	14.15	14.32	-1.3%	2.281	2.280
2500.237	7.977	7.977	0.000 ( +0.0% )	11.42	14.67	-22.1%	1.576	1.566
2500.241	9.405	9.405	0.000 ( +0.0% )	3.89	3.93	-0.8%	1.956	1.959
2500.242	10.331	10.331	0.000 ( +0.0% )	0.88	0.87	+1.1%	1.729	1.727
2500.243	2.712	2.712	0.000 ( +0.0% )	5.70	7.97	-28.5%	1.060	1.063
2500.244	485.976	485.976	0.000 ( +0.0% )	0.55	0.57	-4.0%	1.671	1.675
2500.245	823.224	823.224	0.000 ( +0.0% )	0.74	0.76	-2.1%	1.661	1.660
2500.901	1.749	1.749	0.000 ( +0.0% )	21.48	21.87	-1.8%	1.832	1.829
2500.902	1.598	1.598	0.000 ( +0.0% )	22.15	21.95	+0.9%	1.761	1.761
2500.911	13.931	13.931	0.000 ( +0.0% )	3.16	3.08	+2.4%	1.081	1.078
2500.912	0.310	0.310	0.000 ( +0.0% )	1.11	1.21	-7.9%	0.970	0.965
2500.913	0.110	0.110	0.000 ( +0.0% )	1.16	1.21	-4.3%	0.973	0.971

[vlimant]

+1
I think backport is not an option now

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1