Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestBPHSpecificDecay test #45709

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Aug 15, 2024

PR description:

This PR removes a test file since it's giving issues in UBSAN + it's actually tested in DQM, i.e. it's a dupplicate.
See more in #45410

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

Resolves #45410

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2024

cms-bot internal usage

@tvami
Copy link
Contributor Author

tvami commented Aug 15, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami for master.

It involves the following packages:

  • HeavyFlavorAnalysis/SpecificDecay (analysis)

@tvami can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f20a1/40946/summary.html
COMMIT: e5670a4
CMSSW: CMSSW_14_1_X_2024-08-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45709/40946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 93 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422510
  • DQMHistoTests: Total failures: 2469
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420021
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 16, 2024

@elusian @ronchese FYI

@tvami
Copy link
Contributor Author

tvami commented Aug 16, 2024

@elusian @ronchese FYI

I'll give folks a few days to raise objection before signing.

@elusian
Copy link

elusian commented Aug 16, 2024

I'm mostly a user for this code, I'll leave @ronchese to comment here.
Just to understand, is BPHWriteSpecificDecay itself (and thus the DQM sequence) affected?

@tvami
Copy link
Contributor Author

tvami commented Aug 16, 2024

is BPHWriteSpecificDecay itself (and thus the DQM sequence) affected?

no that seems to be fine, and that's why I'm only removing the test

@tvami
Copy link
Contributor Author

tvami commented Aug 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UBSAN] array subscript ... is partly outside array bounds in HeavyFlavorAnalysis/SpecificDecay
5 participants