Add ZDC EtSums to Stage-2 L1T emulation

[missirol]

PR description:

This PR adds the computation of ZDC EtSums to the sequence used for the emulation of the Stage-2 L1T results.

This addresses one of the issues discussed in #43214 (specifically, the L1T-ZDC not firing when using L1REPACK:Full).

See the validation section below for some additional details.

PR validation:

The test in [1] outputs the L1T results (for a few events, using both real data and MC) in three cases: (a) before any re-emulation, (b) re-emulating only the L1-uGT, and (c) re-emulating L1T with L1REPACK:Full (data) or L1REPACK:FullMC (MC).

• Regardless of this PR, the L1T results for ZDC seeds in (a) and (b) agree, as expected.
• Without this PR, all L1T seeds using ZDC accept no events in case (c).
• With this PR, the following happens.
  • The trigger decisions of L1T-ZDC seeds are non-zero in (c) for data (L1REPACK:Full). In this case, the results of (c) are similar to (a/b), but not exactly the same. Solving this discrepancy is beyond the scope of this PR (it is left to L1T and ZDC experts).
  • The trigger decisions of L1T-ZDC seeds are still zero in (c) for MC. I can only guess this is because more basic parts of the simulation of ZDC Trigger Primitives are missing in CMSSW. This too is beyond the scope of this PR, and it is left to domain experts.

[1]

#!/bin/bash

[ $# -ge 1 ] || exit 1

outDir="${1}"

[ ! -d "${outDir}" ] || exit 1

mkdir -p "${outDir}"
cd "${outDir}"

execmd="hltGetConfiguration /dev/CMSSW_14_0_0/HIon --no-prescale --output minimal --max-events 100"
execmd+=" --paths HLTriggerFirstPath,HLTriggerFinalPath,HLTAnalyzerEndpath"

hltLabel=hltData_ref
${execmd} \
  --customise HLTrigger/Configuration/CustomConfigs.customiseHLTforHIonRepackedRAWPrime \
  --input root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/hidata/HIRun2023A/HIPhysicsRawPrime0/RAW/v1/000/375/491/00000/de963321-c0a0-49fb-b771-1a312a69db03.root \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

hltLabel=hltData_L1uGT
${execmd} \
  --customise HLTrigger/Configuration/CustomConfigs.customiseL1THLTforHIonRepackedRAWPrime \
  --input root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/hidata/HIRun2023A/HIPhysicsRawPrime0/RAW/v1/000/375/491/00000/de963321-c0a0-49fb-b771-1a312a69db03.root \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --eras Run3_2024 --l1-emulator uGT \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

hltLabel=hltData_L1Full
${execmd} \
  --customise HLTrigger/Configuration/CustomConfigs.customiseL1THLTforHIonRepackedRAWPrime \
  --input root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/hidata/HIRun2023A/HIPhysicsRawPrime0/RAW/v1/000/375/491/00000/de963321-c0a0-49fb-b771-1a312a69db03.root \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --eras Run3_2024 --l1-emulator Full \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

hltLabel=hltMC_ref
${execmd} \
  --input /store/relval/CMSSW_14_0_0/RelValPyquen_DiJet_pt80to120_5362GeV_2023/GEN-SIM-DIGI-RAW-HLTDEBUG/PU_140X_mcRun3_2023_realistic_HI_v3_STD_HIN_PU-v1/2580000/8dda8ff3-5f50-4698-8834-24f2a31a8bf3.root \
  --globaltag 140X_mcRun3_2023_realistic_HI_v3 \
  --mc \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

hltLabel=hltMC_L1uGT
${execmd} \
  --input /store/relval/CMSSW_14_0_0/RelValPyquen_DiJet_pt80to120_5362GeV_2023/GEN-SIM-DIGI-RAW-HLTDEBUG/PU_140X_mcRun3_2023_realistic_HI_v3_STD_HIN_PU-v1/2580000/8dda8ff3-5f50-4698-8834-24f2a31a8bf3.root \
  --globaltag 140X_mcRun3_2023_realistic_HI_v3 \
  --mc \
  --eras Run3_2024 --l1-emulator uGT \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

hltLabel=hltMC_L1FullMC
${execmd} \
  --input /store/relval/CMSSW_14_0_0/RelValPyquen_DiJet_pt80to120_5362GeV_2023/GEN-SIM-DIGI-RAW-HLTDEBUG/PU_140X_mcRun3_2023_realistic_HI_v3_STD_HIN_PU-v1/2580000/8dda8ff3-5f50-4698-8834-24f2a31a8bf3.root \
  --globaltag 140X_mcRun3_2023_realistic_HI_v3 \
  --mc \
  --eras Run3_2024 --l1-emulator FullMC \
  > "${hltLabel}".py && cmsRun "${hltLabel}".py &> "${hltLabel}".log && mv output.root "${hltLabel}".root

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45712/41350

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• Configuration/StandardSequences (operations)
• EventFilter/L1TRawToDigi (l1)
• L1Trigger/Configuration (l1)
• L1Trigger/L1TGlobal (l1)
• L1Trigger/L1TNtuples (l1)
• L1Trigger/L1TZDC (l1)

@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @dinyar, @eyigitba, @fabiocos, @felicepantaleo, @kreczko, @makortel, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[missirol]

Ideally, this fix would enter 14_1_0_pre7. Otherwise, it will likely need to be backported to 14_1_X.

[aloeliger]

+l1

[mandrenguyen]

The tests are stuck, but this appears to be just the comparisons, which I don't think are likely to be useful (L1 signed already anyway).
@missirol are you happy with the responses here:
#45712 (comment)

If so I think we can go ahead and merge this before building pre7.

[missirol]

are you happy with the responses here: #45712 (comment)

Yes. I don't know enough to comment further, but it looks like what is in the configuration is intentional, and this PR is not modifying the value which was there before, so nothing else to do in this PR.

[mandrenguyen]

+1
The tests have passed, it's just a comparison that is stuck.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

[mandrenguyen]

merge

[Martin-Grunewald]

Hi, The file is generated by the fillDescriptions code, https://cmssdt.cern.ch/lxr/source/L1Trigger/L1TZDC/plugins/L1TZDCProducer.cc#0164 and appears under ../cfipython .

…

On Fri, 30 Aug 2024, Andrew Loeliger wrote: @aloeliger commented on this pull request. > @@ -0,0 +1,7 @@ +import FWCore.ParameterSet.Config as cms + +from L1Trigger.L1TZDC.l1tZDCProducer_cfi import l1tZDCProducer as _l1tZDCProducer @missirol I am working through a separate packer problem right now, but running into some ZDC things I don't understand and I'm trying to chase it down to the base of the ZDC emulation, which you must recently touched in this PR. I'm confused by this import (and how I'm not getting python problems) because `L1Trigger.L1TZDC.l1tZDCProducer_cfi` doesn't seem to exist. A quick search on github doesn't seem to reveal any mention of this file other than right here, and I can't find it under L1Trigger/L1TZDC. This PR removed what I remembered as the previous L1Trigger ZDC emulation config `etSumZdcProducer_cfi`, was this perhaps supposed to be a rename of that configuration that didn't end up in the PR? Am I missing some other thing that was done to the ZDC emulation to make this import and producer work? -- Reply to this email directly or view it on GitHub: #45712 (review) You are receiving this because you were mentioned. Message ID: ***@***.***>

[aloeliger]

Hi,

The file is generated by the fillDescriptions code,
https://cmssdt.cern.ch/lxr/source/L1Trigger/L1TZDC/plugins/L1TZDCProducer.cc#0164
and appears under ../cfipython .

On Fri, 30 Aug 2024, Andrew Loeliger wrote:

@aloeliger commented on this pull request.

@@ -0,0 +1,7 @@
+import FWCore.ParameterSet.Config as cms

+from L1Trigger.L1TZDC.l1tZDCProducer_cfi import l1tZDCProducer as _l1tZDCProducer

@missirol I am working through a separate packer problem right now, but running into some ZDC things I don't understand and I'm trying to chase it down to the base of the ZDC emulation, which you must recently touched in this PR. I'm confused by this import (and how I'm not getting python problems) because L1Trigger.L1TZDC.l1tZDCProducer_cfi doesn't seem to exist. A quick search on github doesn't seem to reveal any mention of this file other than right here, and I can't find it under L1Trigger/L1TZDC.

This PR removed what I remembered as the previous L1Trigger ZDC emulation config etSumZdcProducer_cfi, was this perhaps supposed to be a rename of that configuration that didn't end up in the PR? Am I missing some other thing that was done to the ZDC emulation to make this import and producer work?

--
Reply to this email directly or view it on GitHub:
#45712 (review)
You are receiving this because you were mentioned.

Message ID: @.***>

Right, thanks. Sorry for the extra noise.