Avoid copying array in TracksterLinkingbySkeletons

[Dr15Jones]

PR description:

Now pass the array by const&.

PR validation:

Code compiles.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45717/41359

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.cc modified in PR(s): TICLv5 : Superclustering DNN #45333

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22daac/40961/summary.html
COMMIT: 54ca271
CMSSW: CMSSW_14_1_X_2024-08-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45717/40961/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3422487
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1