Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx359P Prepare the material file to be updated later once the composition known for materials for the silicon component of HGCal #45736

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Prepare the material file to be updated later once the composition known for materials for the silicon component of HGCal

PR validation:

Tested with appropriate scripts in Geometry/HGCalCommonData/python/

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…own for materials for the silicon component of HGCal
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d71184/40996/summary.html
COMMIT: 0d07b80
CMSSW: CMSSW_14_1_X_2024-08-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45736/40996/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Aug 18, 2024

+1

@bsunanda , you change indentation in xml for purpose?

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this

@bsunanda
Copy link
Contributor Author

@civanch Yes. For v19 there will be some changes in the material content

@mandrenguyen
Copy link
Contributor

@cms-sw/upgrade-l2 can you have a look please?

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f9a6bb3 into cms-sw:master Aug 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants