-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx359P Prepare the material file to be updated later once the composition known for materials for the silicon component of HGCal #45736
Conversation
…own for materials for the silicon component of HGCal
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45736/41381 |
@cmsbuild Please test |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+1 @bsunanda , you change indentation in xml for purpose? |
@srimanob Please approve this |
@civanch Yes. For v19 there will be some changes in the material content |
@cms-sw/upgrade-l2 can you have a look please? |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Prepare the material file to be updated later once the composition known for materials for the silicon component of HGCal
PR validation:
Tested with appropriate scripts in Geometry/HGCalCommonData/python/
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special