make AlcaPCCEventProducer a global module

[mmusich]

PR description:

I casually stumbled on this module while looking at resource consumption in the HLT menu. I am wondering if we could make it a global module. I profit of the PR to clean-up a bit the naming of variables and const correctness of data-members.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45748/41443

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• Calibration/LumiAlCaRecoProducers (alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[perrotta]

Having had a look at the code and at the (cleaned) class members, I don't see counterindications in making AlcaPCCEventProducer a global module: this PR can get signed by AlCa as soon as the tests succeed

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f14576/41029/summary.html
COMMIT: 0970a66
CMSSW: CMSSW_14_1_X_2024-08-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45748/41029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 84 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422510
• DQMHistoTests: Total failures: 4604
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3417886
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• I don't see counterindications in making AlcaPCCEventProducer a global module
• Differences in test outputs are all from the "usual suspects"

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1