Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++ concepts to deduce data product attributes #45756

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Use concepts for attributes used by Wrapper
  • Use concepts to discover post_insert method

PR validation:

Code compiles and framework unit tests pass.

- Use concepts for attributes used by Wrapper
- Use concepts to discover post_insert method
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45756/41464

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/Common (core)
  • FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

This does the same sort of refactoring as #45753 but uses C++ 20 concepts instead.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a067b1/41041/summary.html
COMMIT: 1599014
CMSSW: CMSSW_14_1_X_2024-08-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45756/41041/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

Comparison failures are related to #39803

@makortel
Copy link
Contributor

Since this PR worked fine with e.g. rootcling, I'd proceed with it and close the #45753

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 43e7ffd into cms-sw:master Aug 21, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the wrapperConcepts branch September 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants