Use C++ concepts for edm::Ptr

[Dr15Jones]

PR description:

Used to improve handling of constructors for edm::Ptr's related to other types.

PR validation:

The code compiles and the relevant unit test passes.

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45770/41483

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• DataFormats/Common (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165322/41073/summary.html
COMMIT: faf33ed
CMSSW: CMSSW_14_1_X_2024-08-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45770/41073/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 8 errors in the following unit tests:

---> test SubmitPVsplit had ERRORS
---> test SubmitPVrbr had ERRORS
---> test createDBObjects had ERRORS
and more ...

RelVals-INPUT

The relvals timed out after 4 hours.

• 2024.0090052024.009005_RunParkingHH2024B_50k/step1_dasquery.log
• 2024.0050052024.005005_RunMuon02024B_50k/step1_dasquery.log
• 2024.1090052024.109005_RunParkingHH2024C_50k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.0131
• 2024.01405
• 2024.01105
• 2024.1051
• 2024.21105
• 2024.40905

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328166
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328137
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mmusich]

-1

failing tests will be fixed by #45764 and #45775

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

ignore tests-rejected with ib-failure

[mandrenguyen]

+1

[mandrenguyen]

+1