-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another workaround for -O3 ASAN compilation issue in CTPPSProtonReconstructionPlotter #45786
Another workaround for -O3 ASAN compilation issue in CTPPSProtonReconstructionPlotter #45786
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45786/41516 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI @dan131riley |
@cmsbuild, please test |
@cmsbuild, please test for CMSSW_14_1_ASAN_X |
-1 Failed Tests: UnitTests Unit TestsI found 2 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS ---> test test_MC_23_setup had ERRORS |
The unit test failure in ASAN is tracked in #45751 |
@cmsbuild, please test Let's (re-)run the normal tests too |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
@cmsbuild ignore tests-rejected with ib-failure |
@cms-sw/dqm-l2 Could you please review and sign? Thanks! |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
I guess this #44931 (comment)
happened. @iarspider Could you open a new issue? |
Maybe we should just build this package with |
Or turn off LTO for this package? |
PR description:
Build of CMSSW_14_1_ASAN_X_2024-08-21-2300 failed with
which is the same error as noted in #44931 (comment) and worked around in #44931 (comment) and #45304. This PR applies the same workaround to other part in this code.
Resolves cms-sw/framework-team#1004
PR validation:
Code compiles in CMSSW_14_1_ASAN_X_2024-08-21-2300