Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx359S Modify the testing code in RecoLocalCalo/HGCalRecAlgos in view of changes made in the Configuration/Geometry area for Phase2 scenarios #45790

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Phase2-hgx359S Modify the testing code in RecoLocalCalo/HGCalRecAlgos in view of changes made in the Configuration/Geometry area for Phase2 scenarios #45790

merged 1 commit into from
Aug 28, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify the testing code in RecoLocalCalo/HGCalRecAlgos in view of changes made in the Configuration/Geometry area for Phase2 scenarios

PR validation:

Tested the scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

Modify the testing code in RecoLocalCalo/HGCalRecAlgos in view of cha…
65d8e1b 
…nges made in the Configuration/Geometry area for Phase2 scenarios
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 24, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45790/41522

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • RecoLocalCalo/HGCalRecAlgos (reconstruction, upgrade)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @cseez, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @missirol, @pfs, @rchatter, @rovere, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6789b7/41114/summary.html
COMMIT: 65d8e1b
CMSSW: CMSSW_14_1_X_2024-08-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45790/41114/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

  • 2024.1140052024.114005_RunZeroBias2024C_50k/step1_dasquery.log
  • 2024.4020052024.402005_RunEGamma02024F_50k/step1_dasquery.log
  • 2024.4030052024.403005_RunHcalNZS2024F_50k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6789b7/41138/summary.html
COMMIT: 65d8e1b
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45790/41138/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328179
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this PR

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@bsunanda bsunanda mentioned this pull request Aug 27, 2024
Merged
@mandrenguyen
Copy link
Contributor

+1

1 similar comment
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 95d44f8 into cms-sw:master Aug 28, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@bsunanda @cmsbuild @jfernan2 @srimanob @mandrenguyen