Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better automatic handling of default 2026 geometry #45796

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 25, 2024

PR description:

This is a follow-up to #45764, in order to enforce that the the "default" 2026 geometry is taken from one unique place (in this case: Configuration/Geometry/python/defaultPhase2ConditionsEra_cff.py).

PR validation:

Checked out the following packages

git cms-addpkg Geometry/TrackerGeometryBuilder/ SimTracker/TrackerMaterialAnalysis RecoTracker/MkFit SLHCUpgradeSimulations/Geometry Alignment/OfflineValidation

in which the default geometry is used and check that all the unit tests run fine with: scram b runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @slomeo, @vargasa this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2024

test paramerters:

  • addpkg = Geometry/TrackerGeometryBuilder , SimTracker/TrackerMaterialAnalysis , RecoTracker/MkFit , SLHCUpgradeSimulations/Geometry , Alignment/OfflineValidation

@mmusich
Copy link
Contributor Author

mmusich commented Aug 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21ad22/41130/summary.html
COMMIT: 5d6cf34
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45796/41130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328182
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@civanch
Copy link
Contributor

civanch commented Aug 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2024

@srimanob now that this PR is moved to CMSSW_14_2_X milestone, shall I backport it to CMSSW_14_1_X too or is it an overkill? (I suppose we won't change defaults in CMSSW_14_1_X anymore now).

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@srimanob
Copy link
Contributor

Hi Marco,
To me, it is fine to keep 14_1 as is. I don't think we will touch it for Phase-2.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ab08a21 into cms-sw:master Aug 28, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_better2026Default_handling branch August 28, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants