Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CLCT sorting in CSC TP emulator and synchronize the config to the Point-5 data-taking settings #45829

Merged

Conversation

tahuang1991
Copy link
Contributor

PR description:

  1. update the deadtimezone and pretrigger-trigger match
  2. update the configuration parameter to synchronize with the setting for data-taking at P5

PR validation:

We did test the agreement between OTMB firmware for CSC trigger and CSC TP emulator by injecting simulated muons into OTMB, and finally with these changes and bugfixed firmware, we can achieve a perfect agreement.

Yumeng@yumeng111 presented the results on CSC weekly meeting:
https://indico.cern.ch/event/1450065/contributions/6105639/attachments/2917647/5120368/otmb_cscmeeting.pdf

2. update the configuration parameter to synchronize with the setting for data-taking at P5
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tahuang1991 for master.

It involves the following packages:

  • L1Trigger/CSCTriggerPrimitives (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@JanFSchulte, @Martin-Grunewald, @eyigitba, @giovanni-mocellin, @missirol, @mmusich, @ptcox, @valuev this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tahuang1991
Copy link
Contributor Author

test

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e1813/41244/summary.html
COMMIT: 5f3420b
CMSSW: CMSSW_14_2_X_2024-09-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45829/41244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3fd9e7b into cms-sw:master Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants