Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to sort candidates by pT in Unified Particle Transformer #45843

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR adds a flag to allow to sort by pT the PF candidates and lost tracks used as input features in the Unified Particle Transformer tag producer. While studying the performance of UParT b-tagging in heavy-ion simulations, it was found that sorting the input candidates by pT improved the performance in the most central (0-10%) PbPb collisions.

The flag to sort the candidates by pT is set to false by default, so no changes are expected in the standard configuration.

@mandrenguyen @DickyChant

PR validation:

Tested using ttbar PbPb simulations.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @hqucms, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4615/41202/summary.html
COMMIT: c80c719
CMSSW: CMSSW_14_2_X_2024-08-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45843/41202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fc73bc9 into cms-sw:master Sep 3, 2024
20 checks passed
@stahlleiton stahlleiton deleted the UParT_PtSort_CMSSW_14_1_X branch September 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants