Add CICADA Regions and Score to AOD and MINIAOD formats #45864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
aloeliger
changed the title
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45864/41612 |
|
A new Pull Request was created by @aloeliger for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
missirol
reviewed
Sep 11, 2024
| ] | ||
| obj.outputCommands += cicadaDataRegions | ||
| # Make CICADA available in AOD and miniAOD from 2024 on | ||
| from Configuration.Eras.Modifier_run3_2024_L1T_cff import run3_2024_L1T |
There was a problem hiding this comment.
Given #45713, I think this PR needs to be rebased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
By request of the CICADA team, this PR adds CICADA input collections (Calo Layer 1 regions, an
L1CaloRegionCollection) and CICADA output collections (A bx vector of scores, aCICADABxCollection) to AOD and MINIAOD for Data and MC, for easier studying of the physics potential of the new trigger.As of right now, inputs to any emulation are only available in the RAW data format, which is undesirable on disk at most sites. These changes will make studying triggers based on these inputs much more possible, and datasets much likelier on disk without special requests, or lots of occupied disk space.
PR validation:
Contents of produced Data and MC, MiniAOD and AOD formats have been checked to see that they contained the desired input and output collections.
the EDM Event Size tool was used to check the size added to both formats on O(1000) Data events, and O(100) MC events.
For Data AOD:
For Data MiniAOD:
For MC AOD:
For MC MiniAOD
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport and will not require backporting as of right now.