Patch in MuonBeamspotConstraintValueMapProducer for VertexException

[24LopezR]

PR description:

This PR adresses issue #45189. It consists in a simple patch to catch the VertexException.

PR validation:

This PR fixes exception in issue #45189. Additionaly, basic runTheMatrix tests have been run.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR needs to be backported to 14_1_X and 14_0_X.

@mmusich

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45873/41626

[cmsbuild]

A new Pull Request was created by @24LopezR for master.

It involves the following packages:

• RecoMuon/GlobalTrackingTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @amagitte, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix

[mmusich]

@namapane FYI

[mmusich]

@cmsbuild, please test

[jfernan2]

fixes #45189

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4475ff/41282/summary.html
COMMIT: 21d3103
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45873/41282/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
• 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.101001
• 2024.000001
• 2024.001001
• 2024.100001
• 2024.101001

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328501
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328481
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[24LopezR]

Seems like a few tests were not successful (DAS query error). I don't really know how to overcome this... Please help, thanks.

[mmusich]

Please help, thanks.

likely a DAS glitch. Let's re-try.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4475ff/41311/summary.html
COMMIT: 21d3103
CMSSW: CMSSW_14_2_X_2024-09-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45873/41311/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
• 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.101001
• 2024.000001
• 2024.001001
• 2024.100001
• 2024.101001

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328579
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328553
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

please test
(last trial)

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4475ff/41343/summary.html
COMMIT: 21d3103
CMSSW: CMSSW_14_2_X_2024-09-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45873/41343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 109 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328579
• DQMHistoTests: Total failures: 2854
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3325705
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mmusich]

seems tests are successful here. @24LopezR will you open also backports (both to CMSSW_14_1_X and CMSSW_14_0_X)?

[jfernan2]

+1

[24LopezR]

@mmusich Yes, I will open now the backports

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1