Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx360 Try to introduce the right longitudinal structure to the V10 version of HGCal geometry #45874

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 4, 2024

PR description:

Try to introduce the right longitudinal structure to the V10 version of HGCal geometry

PR validation:

Dump the geometry to be visualized by firework

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45874/41627

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 4, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @bsunanda, @civanch, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33e175/41288/summary.html
COMMIT: 2a00279
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45874/41288/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

Pull request #45874 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 5, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33e175/41309/summary.html
COMMIT: c55b678
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45874/41309/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328501
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328475
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 6, 2024

+geometry

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 6, 2024

@srimanob Please approve this

@srimanob
Copy link
Contributor

srimanob commented Sep 6, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d0b9da8 into cms-sw:master Sep 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants