[FASTSIM] Changes suggested by new llvm18 clang-format

[smuzaffar]

This PR applies clang-format changes suggested by new llvm18 ( see #45870 )

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45902/41657

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• FastSimulation/CTPPSFastGeometry (fastsim)
• FastSimulation/CaloGeometryTools (fastsim)
• FastSimulation/CaloHitMakers (fastsim)
• FastSimulation/Calorimetry (fastsim)
• FastSimulation/Event (fastsim)
• FastSimulation/MaterialEffects (fastsim)
• FastSimulation/ShowerDevelopment (fastsim)
• FastSimulation/SimplifiedGeometryPropagator (fastsim)
• FastSimulation/Tracking (fastsim)
• FastSimulation/TrackingRecHitProducer (fastsim)
• FastSimulation/Validation (fastsim)

@civanch, @cmsbuild, @mdhildreth, @sbein, @ssekmen can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @matt-komm, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[sbein]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31a644/41351/summary.html
COMMIT: 14f3af3
CMSSW: CMSSW_14_2_X_2024-09-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45902/41351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3435122
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3435094
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1