Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SiStripBadStrip_PayloadInspector after merging of cms-sw/cmssw#45795 #45954

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 9, 2024

fixes #45952

PR description:

Title says it all, after #45795 was merged (in particular commit 68c2b44), it's not needed anymore to draw an empty "ghost" map as a background when some of the SiStripTkMap bins are empty.

PR validation:

scram b runtests_testSiStripPayloadInspector runs fine with this change.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Sep 9, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 9, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/SiStripPlugins (db)

@consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a5ff9/41404/summary.html
COMMIT: 7faf3ef
CMSSW: CMSSW_14_2_X_2024-09-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45954/41404/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331158
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331138
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@cms-sw/db-l2 , can you please review this change? This fixes the failing unit tests in IBs

@perrotta
Copy link
Contributor

perrotta commented Sep 9, 2024

+db

  • CondCore/SiStripPlugins that fail in the IB do not fail here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Sep 10, 2024

urgent

  • fixes broken IB tests

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSiStripPayloadInspector: SIGSEGV in SiStripTkMaps::drawMap
5 participants