Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEM TnP efficiency plots with bad VFAT masking and Etapartition-wise measurements (backport of #45676, 14_0_X) #45962

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jo100sun
Copy link
Contributor

@jo100sun jo100sun commented Sep 9, 2024

PR description:

Backport of (https://github.com/cms-sw/cmssw/pull/45676)[https://github.com/https://github.com/cms-sw/cmssw/pull/45676]. This PR introduces etapartition-wise measurement and VFAT masking of GEM TnP efficiency

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is backport of (https://github.com/cms-sw/cmssw/pull/45676)[https://github.com/https://github.com/cms-sw/cmssw/pull/45676]. We would like to introduce this changes for upcoming run.

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

A new Pull Request was created by @jo100sun for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/MuonDPG (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @abbiendi, @barvic, @bellan, @calderona, @cericeci, @jhgoh, @ptcox, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

cms-bot internal usage

@antoniovagnerini
Copy link

please test

@antoniovagnerini
Copy link

backport of #45676

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f560fe/41448/summary.html
COMMIT: 5f431f2
CMSSW: CMSSW_14_0_X_2024-09-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45962/41448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3346841
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346812
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1831.5049999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 96.395 KiB GEM/Segment_TnP
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bca9ca9 into cms-sw:CMSSW_14_0_X Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants