Fix mismatch between EB and EE recHits in Phase2 supercluster producer configs

[RSalvatico]

PR description:

Several Phase2 HLT modules using the PFECALSuperClusterProducer are taking as input the EcalRecHitsEE as barrelRecHits and EcalRecHitsEB as endcapRecHits. These are not used in the building of the moustache supercluster, which is the only supercluster algorithm used online at the moment, also for Phase2. Nevertheless, this is still a nasty bug and could cause problems in the future - they are in fact used for example for the DNN supercluster in PFECALSuperClusterAlgo.

I have not found offline modules with the same issue - I think they are all created by the fillDescription of the PFECALSuperClusterProducer, which is correct.

On the other hand, note that the modules hltParticleFlowSuperClusterECALL1Seeded and hltParticleFlowSuperClusterECALUnseeded in ConfDB present the same issue and should be fixed as well.

PR validation:

As explained above, I would not expect to see differences.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45973/41732

[cmsbuild]

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VourMa, @argiro, @missirol, @mmusich, @rchatter, @rovere, @silviodonato, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[mmusich]

type egamma, bug-fix

[mmusich]

@RSalvatico

On the other hand, note that the modules hltParticleFlowSuperClusterECALL1Seeded and hltParticleFlowSuperClusterECALUnseeded in ConfDB present the same issue and should be fixed as well.

Please open a CMSHLT JIRA ticket for this.

[RSalvatico]

@RSalvatico

On the other hand, note that the modules hltParticleFlowSuperClusterECALL1Seeded and hltParticleFlowSuperClusterECALUnseeded in ConfDB present the same issue and should be fixed as well.

Please open a CMSHLT JIRA ticket for this.

For the records:
https://its.cern.ch/jira/browse/CMSHLT-3329

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cafbf2/41449/summary.html
COMMIT: c35176a
CMSSW: CMSSW_14_2_X_2024-09-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45973/41449/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 179 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331132
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• no changes observed in phase2 trigger decisions, none expected
• fix uncontroversial

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1