Several improvements to L1 tracking code

[tomalin]

PR description:

This consists of several improvements from the Phase 2 L1 tracking group.

1. "combined" versions of the prompt & displaced tracking are now run by default, corresponding to the current firmware choice.
2. Serious bugs were fixed in the duplicate track removal.
3. The L1 Track Quality variable is digitized according to the latest agreement.
4. The tracking performance plotting ROOT macro L1TrackNtupleMaker.C now prints both fake track rate and duplicate track rate in its summary printout.
5. For the HYBRID_NEWKF version of the L1 tracking, which corresponds to FW, but is not the current default for L1 trigger studies, the Kalman Filter Track fit EDProducers have been significantly rearranged, with the advantage that the output TTTrack collection is now created from the end of the chain, and so includes the TrackQuality variable.
6. Truncation has been reduced in the MatchProcessor module.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41733

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41733/cms-checkout-topic.log

[tomalin]

This PR should be noted by @aehart and @skinnari and @zdemirag .

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41736

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41736/cms-checkout-topic.log

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41738

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
  • File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
  • File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41738/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41738/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45974/41742

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/TrackFindingTracklet/plugins/L1FPGATrackProducer.cc modified in PR(s): Displaced vertexing gbdt #45672
  • File L1Trigger/TrackFindingTracklet/python/Producer_cfi.py modified in PR(s): L1Trk reco enabling CheckHistory by default #43690, Displaced vertexing gbdt #45672
  • File L1Trigger/TrackFindingTracklet/python/l1tTTTracksFromTrackletEmulation_cfi.py modified in PR(s): Displaced vertexing gbdt #45672

[cmsbuild]

A new Pull Request was created by @tomalin for master.

It involves the following packages:

• L1Trigger/TrackFindingTracklet (l1)
• L1Trigger/TrackerDTC (l1, upgrade)
• L1Trigger/TrackerTFP (l1)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here