backport in 14_1_X of PR#45993: bug-fix: remove DoubleSensGeomDet (ph-2 InnerTracker)

[emiglior]

PR description:

type bug-fix: this PR fixes the CMSSW issues #43097 and #45792 removing the DoubleSensGeomDet introduced for phase-2 Inner Tracker modules (T33 tracker geometry and following T35, T36, T37, T38 and T39) but actually not used in the code (and unlikely to be used in future).

No changes expected for the output.

PR validation:

Tested on:

• issue Problem in dumping Fireworks Geometry #43097
  cmsRun Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2026 version=D110
  (up to version D113)
• issue Geometry D110: failure in creating Tracker misalignment scenarios #45792
  cmsRun Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py
• D110: runTheMatrix.py --what upgrade -l 29607.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport in 14_1_X of the bug-fix #45993
Needed to test TkAlignment on MC samples produced in 14_1_X with 2026D110/T35 geometry

@henriettepetersen @Raffaella07 @bartosik-hep @sroychow @mdelcourt @srimanob FYI

[cmsbuild]

A new Pull Request was created by @emiglior for CMSSW_14_1_X.

It involves the following packages:

• Alignment/TrackerAlignment (alca)
• Configuration/AlCa (alca)
• Fireworks/Geometry (visualization)
• Geometry/TrackerGeometryBuilder (geometry)
• RecoTracker/MeasurementDet (reconstruction)

@Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @adewit, @alja, @bsunanda, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tlampen, @tocheng, @venturia, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from bugfix: remove DoubleSensGeomDet (ph-2 InnerTracker) #45993

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #45993

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d89a85/41497/summary.html
COMMIT: d5b16aa
CMSSW: CMSSW_14_1_X_2024-09-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45996/41497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 171 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3435125
• DQMHistoTests: Total failures: 6386
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428719
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 166 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[civanch]

+1

[perrotta]

In the master version of this PR you modify Fireworks/Geometry/src/FWRecoGeometryESProducer.cc and you don't modify it here: ok, in the master you had to revert #45784.

In this 14_1_X backport you modify Fireworks/Geometry/python/dumpRecoGeometry_cfg.py : ok, you are backporting the corresponding update previously merged in master with #45328. You did not add the unit test, but ok: it is tested in the master nonetheless

Adding some explanation of what above in the PR description would have simplified the review...

[perrotta]

+alca

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1