Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy CUDA modules for HCAL unpacking and local reconstruction #46004

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 13, 2024

PR description:

Remove legacy CUDA modules for HCAL local reconstruction.
The alpaka version has been commissioned and used in production.

Remove legacy CUDA modules for HCAL unpacker.
The outcome of the discussion with the HCAL DPG is that:

  • for Run 3 we should use the legacy cpu unpacker, and the alpaka version of the legacy-to-SoA converter;
  • for Phase 2 the decision can be revisited once the final raw and digi formats are defined.

PR validation:

None.

The outcome of the discussion with the HCAL DPG is that
  - for Run 3 we should use the legacy cpu unpacker, and the alpaka
    version of the legacy-to-SoA converter;
  - for Phase 2 the decision can be revisited once the final raw and
    digi formats are defined.
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 13, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 13, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 13, 2024

FYI @mariadalfonso @kakwok @igv4321.

Let me know if you spot other left overs.
I plan to remove the actual workflows in a separate PR.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46004/41783

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • CUDADataFormats/HcalDigi (reconstruction, heterogeneous)
  • CUDADataFormats/HcalRecHitSoA (reconstruction, heterogeneous)
  • CondFormats/DataRecord (db, alca)
  • CondFormats/HcalObjects (db, alca)
  • EventFilter/HcalRawToDigi (reconstruction)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)

@consuegs, @francescobrivio, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @sameasy, @seemasharmafnal, @thomreis, @tocheng, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard mentioned this pull request Sep 13, 2024
51 tasks
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cac56d/41511/summary.html
COMMIT: 317f4c2
CMSSW: CMSSW_14_2_X_2024-09-13-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46004/41511/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 8.08.0_BeamHalo/step3_BeamHalo.log
  • 7.37.3_CosmicsSPLoose2018/step3_CosmicsSPLoose2018.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 134.813134.813_RunCosmics2015C/step2_RunCosmics2015C.log
  • 136.733136.733_RunCosmics2016B/step2_RunCosmics2016B.log
Expand to see more relval errors ...

GPU Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants