-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] remove unused DoubleSendGeomDet
for ph-2 InnerTracker
#46030
base: CMSSW_14_0_X
Are you sure you want to change the base?
[14.0.X] remove unused DoubleSendGeomDet
for ph-2 InnerTracker
#46030
Conversation
type bug-fix |
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
test parameters:
|
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+1 |
+alca |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #45993
PR description:
This PR fixes the CMSSW issues #43097 and #45792 removing the DoubleSensGeomDet introduced for phase-2 Inner Tracker modules (T33 tracker geometry and following T35, T36, T37, T38 and T39) but actually not used in the code (and unlikely to be used in future).
No changes expected for the output.
PR validation:
Tested on:
cmsRun Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2026 version=D110
cmsRun Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py
runTheMatrix.py --what upgrade -l 29607.0
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport in 14_0_X of the bug-fix #45993
Needed to test TkAlignment on MC samples produced in 14_1_X with 2026D110/T35 geometry