Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] remove unused DoubleSendGeomDet for ph-2 InnerTracker #46030

Open
wants to merge 1 commit into
base: CMSSW_14_0_X
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 18, 2024

backport of #45993

PR description:

This PR fixes the CMSSW issues #43097 and #45792 removing the DoubleSensGeomDet introduced for phase-2 Inner Tracker modules (T33 tracker geometry and following T35, T36, T37, T38 and T39) but actually not used in the code (and unlikely to be used in future).

No changes expected for the output.

PR validation:

Tested on:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport in 14_0_X of the bug-fix #45993
Needed to test TkAlignment on MC samples produced in 14_1_X with 2026D110/T35 geometry

@mmusich
Copy link
Contributor Author

mmusich commented Sep 18, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Fireworks/Geometry (visualization)
  • Geometry/TrackerGeometryBuilder (geometry)
  • RecoTracker/MeasurementDet (reconstruction)

@Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @alja, @bsunanda, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @venturia, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 18, 2024

test parameters:

  • workflow_opts = -w upgrade
  • workflows = 29607.0

@mmusich
Copy link
Contributor Author

mmusich commented Sep 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1fda1/41576/summary.html
COMMIT: 7cf7259
CMSSW: CMSSW_14_0_X_2024-09-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46030/41576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3553817
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553794
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 211 log files, 174 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@alja
Copy link
Contributor

alja commented Sep 18, 2024

+1

@perrotta
Copy link
Contributor

+alca

@civanch
Copy link
Contributor

civanch commented Sep 19, 2024

+1

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants