Hack to make "Output Module Inserter" support plugin-type names with :
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
reviewed
Mar 6, 2024
| // "pluginType", "pluginType:moduleLabel", or "copy:pluginType:moduleLabel". | ||
| // Unfortunately, this convention does not take into account the fact that | ||
| // pluginType itself can contain the substring "::" (e.g. plugin types with namespace specification, | ||
| // or Alpaka plugins with explicit backend selection). |
There was a problem hiding this comment.
Suggested change
| // or Alpaka plugins with explicit backend selection). | |
| // likw Alpaka plugins with explicit backend selection). |
fwyzard
reviewed
Mar 6, 2024
Comment on lines
3076
to
3077
| // The hack below consists in replacing "::" in "name" with | ||
| // a very unlikely string without colons, before "name" is split by ":". |
There was a problem hiding this comment.
Suggested change
| // The hack below consists in replacing "::" in "name" with | |
| // a very unlikely string without colons, before "name" is split by ":". | |
| // The hack below consists in replacing "::" in "name" with "##", | |
| // before "name" is split by ":". |
fwyzard
reviewed
Mar 6, 2024
| // a very unlikely string without colons, before "name" is split by ":". | ||
| // After that, the replacement of "::" with this unlikely string is undone in "templateName". | ||
| // NOTE. | ||
| // This hack assumes that plugin types in CMSSW will never have "##" in their name. |
There was a problem hiding this comment.
Suggested change
| // This hack assumes that plugin types in CMSSW will never have "##" in their name. | |
| // This hack assumes that plugin types in CMSSW will never have "##" in their name, | |
| // since that would be invalid in C++. |
missirol
force-pushed
the
devel_hackOutModInsert
branch
from
7c757a2
to
40fc40d
Compare
|
Is there anything outstanding in this PR or can we merge it (and create a new tag)? |
|
From my side, I think we can go ahead. (I think I implemented the comments, and I did some manual tests of this PR editing and saving a config in the GUI) |
|
Yes. |
mmusich
added a commit
that referenced
this pull request
Mar 11, 2024
mmusich
added a commit
that referenced
this pull request
Mar 11, 2024
mmusich
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #85, in light of the discussion in #86.
The production HLT menus need to include plugin types with
:in their name (e.g.alpaka_serial_sync::*), and the "Output Module Inserter" currently does not support adding this kind of modules via the GUI (parsing of these modules directly from python works without issue).This PR introduces a workaround to fix this GUI issue. More details are given in the comment in the source code.
This PR is only a GUI improvement. It is not strictly needed to release a new version of the GUI with this right away, and it is a "minor" update (meaning, it does not trigger a "major" release update for the next release of this package).