Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #202

Closed
vivek425ster opened this issue Mar 10, 2016 · 21 comments
Closed

Tests are failing #202

vivek425ster opened this issue Mar 10, 2016 · 21 comments

Comments

@vivek425ster
Copy link
Contributor

Attached is the log when I ran py.test
http://pastebin.com/f5MEsZDF

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

Could you please share also which commandos you used to get coala-bears and how do you executed the tests? If you use a virtual environment or similar please also post the commandos used for setup, activation etc. :)

Which platform do you use btw?

@vivek425ster
Copy link
Contributor Author

@Makman2 Hi,
I am working on ubuntu14.04 x86-64.
I followed these instructions to install coala-bears.
http://coala.readthedocs.org/en/latest/Users/Install.html#installing-coala-from-source
I din't use virtual environment. I installed it directly using sudo.
I executed it using py.test --resultlog
and this is the initial line:
platform linux -- Python 3.4.3, pytest-2.9.0, py-1.4.31, pluggy-0.3.1

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

I see you don't use all plugins we need, like coverage.
Please do sudo pip3 install -r test-requirements.txt --upgrade inside the coala-bears repo to install all test-requirement an re-execute tests.
Tried on ubuntu 14.04 latest packages (except kernel upgrades), but can't reproduce.

@vivek425ster
Copy link
Contributor Author

@Makman2
All my requirements are already up to date
Requirement already up-to-date: coverage>=4.0.3 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 1))
Requirement already up-to-date: pytest>=2.8.7 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 2))
Requirement already up-to-date: pytest-cov>=2.2.1 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 3))
Requirement already up-to-date: pytest-env>=0.6.0 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 4))
Requirement already up-to-date: pytest-timeout>=1.0.0 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 5))
Requirement already up-to-date: pytest-xdist>=1.14 in /usr/local/lib/python3.4/dist-packages (from -r test-requirements.txt (line 6))
Still 16 tests are failing
=================================== 16 failed, 148 passed, 34 skipped, 2 pytest-warnings in 32.33 seconds ====================================

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

could you again provide the complete log? with commando and also the plugins, so just everything?

@vivek425ster
Copy link
Contributor Author

The complete log which is present in stdout: http://pastebin.com/uK5FAxHd
The log as a result of py.test --resultlog=logfile : http://pastebin.com/mJRGARUW

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

alright I got your output now, this is for npm packages. Though that's an npm issue, e.g. executing bootlint itself using bootlint --version yields:

mak@ubuntu:~/dev/coala-bears(master)$ bootlint --version
/usr/bin/env: node: No such file or directory

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

see nodejs/node-v0.x-archive#3911

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

Alright you need to also install nodejs-legacy and then install your node packages. Then this should work 👍

@sils
Copy link
Member

sils commented Mar 10, 2016

@Makman2 the issue is that tests should be skipped automatically! If they
aren't the bears won't have proper error messages as well

Sincerely,

Lasse Schuirmann

contact@viperdev.io
http://viperdev.io/

2016-03-10 19:12 GMT+01:00 Mischa Krüger notifications@github.com:

Alright you need to also install nodejs-legacy and then install your node
packages. Then this should work [image: 👍]


Reply to this email directly or view it on GitHub
#202 (comment)
.

@AbdealiLoKo
Copy link
Contributor

An FYI from an Ubuntu user who has faced this issue many times : It's better to use nvm than rely on those Ubuntu packages.

https://github.com/creationix/nvm

@vivek425ster
Copy link
Contributor Author

@Makman2
I installed nodejs-legacy using sudo apt-get install nodejs-legacy
Still 7 tests are failing.
Also should i add nodejs-legacy in the deps.sh file or package.json ?

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

no nodejs-legacy is an aptitude package, not an npm package :)
and deps.sh is for our CI, you don't need to modify it since it works already 👍

@sils1297 test skipping is not the issue here. the executables do exist but somehow they don't start because node seems not to be found (though it exists too). This is a dependency problem inside Ubuntu, as stated in my linked issue^^

@Makman2
Copy link
Member

Makman2 commented Mar 10, 2016

@vivek425ster btw please add again your test output, I can't see what tests are still failing 👍

@AbdealiLoKo
Copy link
Contributor

We don't check in bears if the programming language is installed. Ie if java or node or ruby or r is not installed ... Tests will fail.
We only check for the package. We discussed this earlier and decided it's the package managers role to install all deps of a linter.
The reason for this confusion is a name conflict between an existing package node and the nodejs in Ubuntu. So this is a big in Ubuntu repos really ...

-----Original Message-----
From: "Lasse Schuirmann" notifications@github.com
Sent: ‎10-‎03-‎2016 23:46
To: "coala-analyzer/coala-bears" coala-bears@noreply.github.com
Subject: Re: [coala-bears] Tests are failing (#202)

@Makman2 the issue is that tests should be skipped automatically! If they
aren't the bears won't have proper error messages as well

Sincerely,

Lasse Schuirmann

contact@viperdev.io
http://viperdev.io/

2016-03-10 19:12 GMT+01:00 Mischa Krüger notifications@github.com:

Alright you need to also install nodejs-legacy and then install your node
packages. Then this should work [image: 👍]


Reply to this email directly or view it on GitHub
#202 (comment)
.


Reply to this email directly or view it on GitHub.

@vivek425ster
Copy link
Contributor Author

@AbdealiLoKo
Copy link
Contributor

Here's my analysis:

  • GoVetBear: This is a known issue (GoVetBear - skip condition invalid #49) and should be fixed. If you want it to pass for now, install golang-go.tools using apt-get
  • ProseLintBear: This is another issue I've faced before. This happens when you use the 0.12.x version of nodejs (which is used in Ubuntu's apt-get). nodeJS has come up to v5.x.x and it would be best if you installed nvm and used that to get the latest node. It's a proselint bug - proselint doesnt work with old nodes I guess ?
  • LanguageToolBear: Now this one is interesting. I think this could also be because you use an older version of nodejs. But I cannot reproduce it right now.

EDIT:
LanguageToolBear uses java. It cannot be a nodejs issue. I still need to debug that.

@AbdealiLoKo
Copy link
Contributor

@vivek425ster Have you installed various web technologies in your laptop ?
I remember xmpp using the port 8081 and maybe that is clashing with LanguageTool ?
Or have you used port 8081 for anything else at all that you know of ?

@AbdealiLoKo
Copy link
Contributor

@vivek425ster still facing this ? Was it solved ?

@vivek425ster
Copy link
Contributor Author

@AbdealiJK did not try it afterwards .

@AbdealiLoKo
Copy link
Contributor

@vivek425ster Closing this as it is very old and nobody else has faced it since then.
I do think it was a system configuration where some port was clashing.

If someone faces this issue again, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants