Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow numeric input for Content-Format and Accept options #363

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jan 5, 2023

This PR introduces the possibility of passing numeric Content-Formats as option values to the setHeader method and adjusts the allowed request parameters.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3850969466

  • 17 of 19 (89.47%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.719%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/option_converter.ts 17 19 89.47%
Totals Coverage Status
Change from base Build 3820725058: -0.1%
Covered Lines: 2854
Relevant Lines: 3069

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 5, 2023

Pull Request Test Coverage Report for Build 3852188808

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.903%

Totals Coverage Status
Change from base Build 3820725058: 0.05%
Covered Lines: 2866
Relevant Lines: 3077

💛 - Coveralls

@JKRhb JKRhb marked this pull request as ready for review January 6, 2023 02:58
@JKRhb JKRhb requested a review from Apollon77 January 6, 2023 02:59
@Apollon77
Copy link
Collaborator

All fine, ok for me to merge

@JKRhb JKRhb merged commit a80eba4 into coapjs:master Jan 6, 2023
@JKRhb JKRhb deleted the numeric-options branch January 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants