Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New try to fix the pr for the Fixed build issuee can only be default-imported using the 'esModule #383

Merged
merged 3 commits into from
Mar 26, 2024
Merged

New try to fix the pr for the Fixed build issuee can only be default-imported using the 'esModule #383

merged 3 commits into from
Mar 26, 2024

Conversation

JimmyBjorklund
Copy link
Contributor

@JimmyBjorklund JimmyBjorklund mentioned this pull request Mar 26, 2024
Closed
@JKRhb JKRhb linked an issue Mar 26, 2024 that may be closed by this pull request
Library is still broken #382
Closed
@JKRhb
Copy link
Member

JKRhb commented Mar 26, 2024

Thank you, @JimmyBjorklund, now the workflows are working again :) Very weird that the checks weren't running in the other PR 🤔

@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8433103350

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 91.798%
Totals Coverage Status
Change from base Build 7768545452: 0.002%
Covered Lines: 2878
Relevant Lines: 3089
💛 - Coveralls

@JKRhb
Copy link
Member

JKRhb commented Mar 26, 2024

Hmm, now it seems like there is a Node 20 related issue :/

@Apollon77
Copy link
Collaborator

@JKRhb #380 ?

@JKRhb
Copy link
Member

JKRhb commented Mar 26, 2024

@JKRhb #380 ?

Oh, right 😅 Then I guess we can merge this one and continue working on #380 afterward? :)

@Apollon77
Copy link
Collaborator

ok for me

@JKRhb JKRhb merged commit 0cf32fa into coapjs:master Mar 26, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollon77 Apollon77 Apollon77 approved these changes

@JKRhb JKRhb JKRhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library is still broken
4 participants
@JimmyBjorklund @JKRhb @coveralls @Apollon77