tests: invert the conditions for checking modular vs monolithic daemon distro #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
You need to force-push for the pycodestyle error anyway. |
KKoukiou
force-pushed
the
modular-daemons
branch
from
dec2d85
to
a123104
Compare
martinpitt
previously approved these changes
Nov 11, 2021
| @@ -57,7 +57,7 @@ systemctl start firewalld | |||
| firewall-cmd --add-service=cockpit --permanent | |||
| firewall-cmd --add-service=cockpit | |||
|
|
|||
| if grep -Eq 'PLATFORM_ID=.*(f35)' /etc/os-release; then | |||
| if grep -Eq 'PLATFORM_ID=.*(f35|f36|el9)' /etc/os-release; then | |||
There was a problem hiding this comment.
I think we should invert that too, and not do it on f34 and el8. But that can also be a follow-up the next time we have to touch this file.
|
This flake is fixed by #448. Let's rebase this PR after that lands, to not totally ruin our test stats. |
martinpitt
force-pushed
the
modular-daemons
branch
from
0b7b03c
to
c25c711
Compare
martinpitt
previously approved these changes
Nov 11, 2021
KKoukiou
force-pushed
the
modular-daemons
branch
from
c25c711
to
f2acb18
Compare
…n distro We should have a list that shrinks - not grows.
…cket manual start
martinpitt
force-pushed
the
modular-daemons
branch
from
f2acb18
to
7b4cedc
Compare
|
Branch was out of date, so packit srpm build failure. Here it actually matters, so I pushed a rebase. |
martinpitt
approved these changes
Nov 11, 2021
|
tests succeeded also downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have a list that shrinks - not grows