Commits on Dec 8, 2016

1. vendor: add fake imports for glide's benefit …

   We've repeatedly encountered issues arising from the fact that entries
   in `glide.yaml` are not treated as the, or even as additional, roots in
   the calulation of the transitive dependency closure.
   
   Previously in cockroachdb#11797, we attempted to clarify the situation by pruning
   all derivable specs from `glide.yaml`, so that it would be clear where
   the dependency roots were indeed coming from.
   
   We however left vendored tools, and their transitive dependencies,
   there, as they were not derivable from any imports (e.g. some are not
   importable due to `package main`).
   
   As we've already found though, simply adding a tool to `glide.yaml`, or
   even `glide get`'ing them, doesn't work.
   
   Thus, to reliably vendor tools and their dependencies, we need to
   introduce artifical imports of them. We get around the `package main`
   issue with by hiding the imports in a file that is build-tagged `+glide`
   so we never attempt to build it.
   
   ---
   
   The `glide up` used to test this picked up a test-only raft change,
   etcd-io/etcd#6935, and:
   
   - golang/tools@ae1141f...3d92dd6
   - cockroachdb/cockroach-go@2c874f1...140a8c5
   - etcd-io/etcd@cfd10b4...b713113
   - distribution/distribution@67095fb...844b928
   - google/go-github@171a931...43e7458
   - opencontainers/runc@5974b4c...34f23cb

   

   dt authored and tamird committed Dec 8, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 49ec3fe
   • Browse repository at this point

   Copy the full SHA

   49ec3fe View commit details

   Browse the repository at this point in the history