ui/next: update dependencies #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably includes typings 1.0.0. NB: There are external definitions available for es6-promise, but isomorphic-fetch's definitions depend on es6-promise's ambient definitions. Also note that redux ships with external definitions, but none of the react packages do, and the react packages' global definitions have not been updated for use with the new external redux definitions. Finally, a manual override was necessary to make reselect's external typings load via plugin-typescript. This appears to be a bug, since this exact information is present in reselect's package.json. Discussion is ongoing in frankwallis/plugin-typescript#102.
|
LGTM, but you'll definitely want to run this by @mrtracy |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably includes typings 1.0.0.
NB: There are external definitions available for es6-promise, but
isomorphic-fetch's definitions depend on es6-promise's ambient
definitions.
Also note that redux ships with external definitions, but none of the
react packages do, and the react packages' global definitions have not
been updated for use with the new external redux definitions.
Finally, a manual override was necessary to make reselect's external
typings load via plugin-typescript. This appears to be a bug, since
this exact information is present in reselect's package.json.
Discussion is ongoing in frankwallis/plugin-typescript#102.
This change is