Enable supports_comments

Fixes: #254

Also
- update requirements for SQLA 2.0.34
- update CI for CRDB v24.2

.github/workflows/ci.yml

@@ -40,9 +40,9 @@ jobs:
       fail-fast: false
       matrix:
         crdb-version: [
-          "cockroach:latest-v23.1",
           "cockroach:latest-v23.2",
-          "cockroach:latest-v24.1"
+          "cockroach:latest-v24.1",
+          "cockroach:latest-v24.2"
         ]
         db-alias: [
           "psycopg2",

dev-requirements.txt

@@ -1,12 +1,12 @@
 backports-tarfile==1.2.0
     # via jaraco-context
-certifi==2024.7.4
+certifi==2024.8.30
     # via requests
-cffi==1.16.0
+cffi==1.17.0
     # via cryptography
 charset-normalizer==3.3.2
     # via requests
-cryptography==43.0.0
+cryptography==43.0.1
     # via secretstorage
 distlib==0.3.8
     # via virtualenv
@@ -16,15 +16,15 @@ filelock==3.15.4
     # via
     #   tox
     #   virtualenv
-idna==3.7
+idna==3.8
     # via requests
-importlib-metadata==8.2.0
+importlib-metadata==8.4.0
     # via
     #   keyring
     #   twine
 jaraco-classes==3.4.0
     # via keyring
-jaraco-context==5.3.0
+jaraco-context==6.0.1
     # via keyring
 jaraco-functools==4.0.2
     # via keyring
@@ -38,7 +38,7 @@ markdown-it-py==3.0.0
     # via rich
 mdurl==0.1.2
     # via markdown-it-py
-more-itertools==10.3.0
+more-itertools==10.4.0
     # via
     #   jaraco-classes
     #   jaraco-functools
@@ -70,7 +70,7 @@ requests-toolbelt==1.0.0
     # via twine
 rfc3986==2.0.0
     # via twine
-rich==13.7.1
+rich==13.8.0
     # via twine
 secretstorage==3.3.3
     # via keyring
@@ -88,5 +88,5 @@ urllib3==2.2.2
     #   twine
 virtualenv==20.26.3
     # via tox
-zipp==3.19.2
+zipp==3.20.1
     # via importlib-metadata

sqlalchemy_cockroachdb/base.py

@@ -86,7 +86,6 @@ def __init__(self):
 
 class CockroachDBDialect(PGDialect):
     name = "cockroachdb"
-    supports_comments = False
     supports_empty_insert = True
     supports_multivalues_insert = True
     supports_sequences = False

sqlalchemy_cockroachdb/requirements.py

@@ -155,6 +155,11 @@ class Requirements(SuiteRequirementsSQLA, SuiteRequirementsAlembic):
     implicitly_named_constraints = exclusions.open()
     supports_distinct_on = exclusions.open()
 
+    fk_ondelete_noaction = exclusions.closed()
+    fk_ondelete_restrict = exclusions.closed()
+    fk_onupdate = exclusions.closed()
+    fk_onupdate_restrict = exclusions.closed()
+
     @property
     def sync_driver(self):
         return exclusions.only_if(

test-requirements.txt

@@ -4,7 +4,7 @@ async-timeout==4.0.3
     # via asyncpg
 asyncpg==0.29.0
     # via -r test-requirements.in
-attrs==24.1.0
+attrs==24.2.0
     # via pytest
 futures==3.0.5
     # via -r test-requirements.in
@@ -18,7 +18,7 @@ markupsafe==2.1.5
     # via mako
 mock==5.1.0
     # via -r test-requirements.in
-more-itertools==10.3.0
+more-itertools==10.4.0
     # via -r test-requirements.in
 packaging==24.1
     # via pytest
@@ -32,7 +32,7 @@ py==1.11.0
     # via pytest
 pytest==7.1.3
     # via -r test-requirements.in
-sqlalchemy==2.0.32
+sqlalchemy==2.0.34
     # via
     #   -r test-requirements.in
     #   alembic