Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: load spine asm.js module with js.mem && update spine #15469

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Jun 18, 2023

Re:
https://github.com/cocos/3d-tasks/issues/16867
https://github.com/cocos/3d-tasks/issues/16865

Dep PR

#15454


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PPpro PPpro requested a review from SantyWang June 18, 2023 07:26
@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -50449,9 +50449,10 @@
                 setJitterEffect(jitter: spine.VertexEffect);
                 setSwirlEffect(swirl: spine.VertexEffect);
                 updateRenderData();
                 setListener(id: number, type: number);
-                static getCurrentEvent(): Event;
+                setDebugMode(debug: boolean);
+                getDebugShapes();
             }
             export class wasmUtil {
                 static spineWasmInit(): void;
                 static spineWasmDestroy(): void;
@@ -50465,9 +50466,9 @@
                 static getCurrentListenerID(): number;
                 static getCurrentEventType(): EventType;
                 static getCurrentTrackEntry(): TrackEntry;
                 static getCurrentEvent(): Event;
-                static HEAPU8: Uint8Array;
+                static wasm: any;
             }
         }
         /**
          * @internal Since v3.7.2, this is an engine private type.
@@ -50662,12 +50663,8 @@
             protected _accTime: number;
             protected _playCount: number;
             protected _skeletonCache: __private._cocos_spine_skeleton_cache__SkeletonCache | null;
             protected _animCache: __private._cocos_spine_skeleton_cache__AnimationCache | null;
-            /**
-             * @internal
-             */
-            _curFrame: __private._cocos_spine_skeleton_cache__AnimationFrame | null;
             protected _needUpdateSkeltonData: boolean;
             protected _listener: __private._cocos_spine_track_entry_listeners__TrackEntryListeners | null;
             constructor();
             /**
@@ -50837,12 +50834,8 @@
              */
             updateAnimation(dt: number): void;
             protected _flushAssembler(): void;
             protected _render(batcher: UI): void;
-            /**
-             * @internal
-             */
-            requestDrawData(material: Material, indexOffset: number, indexCount: number): __private._cocos_spine_skeleton__SkeletonDrawData;
             protected _updateBuiltinMaterial(): Material;
             protected _updateAnimEnum(): void;
             protected _updateSkinEnum(): void;
             protected _refreshInspector(): void;

PPpro and others added 2 commits June 18, 2023 16:40
* support debug renderer

* fix cached mode update color

* enable Batch mode

* fix engineInternal
@PPpro PPpro marked this pull request as ready for review June 18, 2023 08:40
@SantyWang SantyWang merged commit 31f7fb6 into cocos:v3.8.0 Jun 19, 2023
23 checks passed
@PPpro PPpro deleted the 380-spine2 branch June 19, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants