Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationCurve #8409

Merged
merged 35 commits into from
Jul 23, 2021
Merged

AnimationCurve #8409

merged 35 commits into from
Jul 23, 2021

Conversation

shrinktofit
Copy link
Contributor

Re: cocos-creator/3d-tasks#

Changelog:
*

@shrinktofit shrinktofit force-pushed the AnimCurve branch 4 times, most recently from 72fda53 to 3967b18 Compare April 13, 2021 06:14
@shrinktofit shrinktofit force-pushed the AnimCurve branch 21 times, most recently from f559776 to 0070b31 Compare April 22, 2021 01:35
@shrinktofit shrinktofit marked this pull request as ready for review April 22, 2021 01:36
@shrinktofit
Copy link
Contributor Author

This PR tends to be in version 3.2+. Please do not merge it into 3.1. @holycanvas

@shrinktofit
Copy link
Contributor Author

The concepts and design document can be found at here.

@shrinktofit shrinktofit force-pushed the AnimCurve branch 2 times, most recently from 75b803c to 72d4ade Compare April 22, 2021 08:44
gameall3d and others added 17 commits July 22, 2021 09:49
.interpMode -> .interpolationMode
RealInterpMode -> RealInterpolationMode
QuaternionInterpMode -> QuaternionInterpolationMode
ExtrapMode -> ExtrapolationMode
.preExtrap -> .preExtrapolation
.postExtrap -> .postExtrapolation
QuaternionCurve -> QuatCurve
QuaternionKeyframeValue -> QuatKeyframeValue
cocos/core/animation/animation-clip.ts Show resolved Hide resolved
const ratios: number[] = [];
const eventGroups: IAnimationEventGroup[] = [];
const events = this.events.sort((a, b) => a.frame - b.frame);
for (const eventData of events) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遗漏

result[joint] = new BoneGlobalTransform();
return result;
}, {} as Record<string, BoneGlobalTransform>);
for (const joint of Object.keys(skeletonFrames)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遗漏

const parentJointName = joint.substring(0, parentJoint);
const parentJointFrame = skeletonFrames[parentJointName];
if (!parentJointFrame) {
warn(`Seems like we have animation for ${joint} but are missing its parent joint ${parentJointName} in animation?`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遗漏

quatTrackEvalStatuses,
} = compressedDataEvalStatus;

for (const curves of this._curves) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for of

curves.evaluate(time, result);
}

for (const { target, curve } of quatTrackEvalStatuses) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for of

// trackConstructor: ColorTrack,
// properties: [['r', 0], ['g', 1], ['b', 2], ['a', 3]],
// } as ConvertMap<Color, ColorTrack>,
// ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要的话就删除


set keys (value) {
this._keys = value;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无意义的 getter setter

return this._commonTargets;
}

set commonTargets (value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无意义的 getter setter

return track;
});

for (const legacyCurve of legacyCurves) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for of

@pandamicro pandamicro merged commit 6d10f68 into cocos:v3.3.0 Jul 23, 2021
@shrinktofit shrinktofit deleted the AnimCurve branch July 23, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants