oai-pmh identifiers use colon to separate namespace and id, not slash #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochkind
changed the title
This is in conformance with oai-pmh non-mandatory guidelines: http://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm It also matches how sample identifier in 'Identify' was being generated before. https://github.com/code4lib/ruby-oai/blob/23e3ac83c43231fbf55f8dfb70175dbe0975b914/lib/oai/provider/response/identify.rb#L24 It was a bug that sample identifier didn't match actual identifiers. Hypothetically, it would have been less backwards-incompat to make sample identifier use slash. But let's use 1.0 to make this conform to oai-pmh guidance. Especially becuase the majority of current users of this gem are probably using it via blacklight_oai_provider, and it was already providing runtime patches to the oai gem to get colon behavior, and had a commit message suggesting it believed it was patching an "identifier bug in oai gem." So let's fix the thing our main user thinks was a bug! https://github.com/projectblacklight/blacklight_oai_provider/blob/f4b25ee43846cb9efc9d5124a8639a496153aa18/config/initializers/oai_patches.rb Closes #38 Ref #61
jrochkind
force-pushed
the
proper_identifiers
branch
from
834649b
to
0ef07df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in conformance with oai-pmh non-mandatory guidelines
It also matches how sample identifier in 'Identify' was being generated before.
ruby-oai/lib/oai/provider/response/identify.rb
Line 24 in 23e3ac8
It was a bug that sample identifier didn't match actual identifiers. Hypothetically, it would have been
less backwards-incompat to make sample identifier use slash, as the Guidelines saying to use colon are not mandatory, it is legal.
But let's use the 1.0 release to make this conform to oai-pmh guidance.
Especially becuase the majority of current users of this gem are probably using it via blacklight_oai_provider, and it was already providing runtime patches to the oai gem to get colon behavior, and had a commit message suggesting it believed it was patching an "identifier bug in oai gem." So let's fix the thing our main user thinks was a bug, for the 1.0 release!
Closes #38
Ref #61