Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make godot-tbloader use the new FileAccess class instead of File #28

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Make godot-tbloader use the new FileAccess class instead of File #28

merged 1 commit into from
Sep 30, 2022

Conversation

EIREXE
Copy link
Contributor

@EIREXE EIREXE commented Sep 26, 2022

No description provided.

@codecat
Copy link
Owner

codecat commented Sep 26, 2022

Is this still compatible with Beta 1? This change looks very recent on the master branch.

@EIREXE
Copy link
Contributor Author

EIREXE commented Sep 27, 2022 •
edited
Loading

Is this still compatible with Beta 1? This change looks very recent on the master branch.

No, it isn't, it's tracking master, you can keep off merging it until that drops if you want

@codecat
Copy link
Owner

codecat commented Sep 27, 2022

Yeah, I'll wait a bit with merging this PR then. Maybe we need a develop branch for the Godot master branch 🤔

@codecat
Copy link
Owner

codecat commented Sep 30, 2022 •
edited
Loading

This has to be rebased on master after e22ae9a. I rebased it manually.

@codecat codecat merged commit 2863508 into codecat:master Sep 30, 2022
@codecat
Copy link
Owner

codecat commented Sep 30, 2022

Thanks for the PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EIREXE @codecat