Added support for texture paths with spaces #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First congratulation on the great plugin, it works really well! While testing a few maps I noticed that TrenchBroom exports texture paths with spaces in quotes. Unfortunately the current tokenizer for the map format ignored the quotes and cut the paths at the first space. I tried to fix this by allowing the tokenizer to skip spaces while parsing the texture scope. It is not the most elegant solution due to introducing scope dependence in the tokenizer but else the entity parsing code was impacted, but it allows usage of spaces in texture filenames now.
|
It seems like I forgot to review this PR, my apologies! 🙈 Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First congratulation on the great plugin, it works really well!
While testing a few maps I noticed that TrenchBroom exports texture paths with spaces in quotes. Unfortunately the current tokenizer for the map format ignored the quotes and cut the paths at the first space.
I tried to fix this by allowing the tokenizer to skip spaces while parsing the texture scope. It is not the most elegant solution due to introducing scope dependence in the tokenizer but else the entity parsing code was impacted, but it allows usage of spaces in texture filenames now.