Add support to use WSEndpoint on Puppeteer #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavertMik
requested changes
Nov 23, 2018
| @@ -59,7 +59,8 @@ const consoleLogStore = new Console(); | |||
| * | |||
| * ```js | |||
| * "chrome": { | |||
| * "executablePath" : "/path/to/Chrome" | |||
| * "executablePath" : "/path/to/Chrome", | |||
| * "browserWSEndpoint": "ws://localhost:3000" | |||
There was a problem hiding this comment.
thanks. Can you add here an example here for using CodeceptJS with browserless.io?
|
I think for such case we are fine without a test |
|
Ok, I will update docs on my own |
1 task
This was referenced Feb 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
With this PR will be possible to use remote chrome instances like https://www.browserless.io/ or docker containers like https://github.com/joelgriffith/browserless.
I saw that currently the project is not mocking Puppeteer and we don't have tests to
_startBrowser, so I don't know how test it. Should I mock Puppeteer?